fix(ui): add spacing betwen the key details in the header #5037
Conversation
valkirilov
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
pd-redis
as code owners
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from d55f733 |
| /> | ||
|
|
||
| <EuiFlexItem className={styles.actions}> | ||
| <Spacer size="m" /> |
There was a problem hiding this comment.
Bonus Points: Not related to the changes of the popover colors, but I fixed this minimal spacing issue as well.
| Before | After |
|---|---|
 |
 |
There was a problem hiding this comment.
Nice, there is a related ticket so it should be closed after this. I will link it to your issue. Tnx!
valkirilov
force-pushed
the
fe/bugfix/RI-7602_browser-key-details-spacing
branch
from
b3ce95b to
16e35f7
Compare
| <Text | ||
| size="s" | ||
| className={cx(styles.subtitleText, { | ||
| className={cx(styles.subtitleText, styles.subtitleTextTTL, { |
There was a problem hiding this comment.
since subtitleText is adding some paddings and you are removing it in subtitleTextTTL, does it make sense to remove the subtitleText class?
There was a problem hiding this comment.
Thanks for pointing it out. I thought we needed it because it comes with additional styling, but I just checked it and it works fine even without it. So, now it's removed, thanks!
re #RI-7602
Description
Added spacing between the key details in the header.
How it was tested
Observe the header with the details about the key (size, ttl, etc.)
Side Quest
Additionally, there was a very odd behavior when you hover over the TTL field and trigger the inline editor. Now, I made some very ugly CSS fixes to make it look like the way before the EUI replacement.
Note: There is a very weird
letter-spacing: -0.12px;and-webkit-font-smoothing: antialiased;applied across the codebase that causes some odd rendering of the font. I didn't touch that, because it looks like a general issue, but we should think about it. Maybe it was a fix related to an old font, but now it makes the current one look blurred.Old
Screen.Recording.2025-10-06.at.16.31.51.mov
Before
Screen.Recording.2025-10-06.at.16.32.23.mov
After
Screen.Recording.2025-10-06.at.16.33.07.mov